Emit timeupdate when calling setTime
#3593
Merged
+79
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jagthedrummer I’ve invited you to be a collaborator so that you can more easily contribute directly to the repo. Cheers! 🚀 |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This makes it so that the regions plugin will fire
region-inandregion-outevents when audio is not loaded into wavesurfer.Resolves #3570
Implementation details
This just fires a
timeupdateevent in thesetTimemethod. This was the smallest change I could make to get the regions plugin to fire events.If there's a better way to make this happen I'd love to hear some suggestions.
How to test it
Use pre-decoded
peaksand adurationto render a wavesurfer with no audio loaded. Add the regions plugin, and add a region. Add aregion-inhandler to the regions plugin, and then callwavesurfer.setTime()with a value inside the region. The handler for theregion-inevent should fire.Screenshots
N/A
Checklist